hendrikvanantwerpen
commented
10 months ago Summary of the work I've done towards this already.
Two PRs exist for the stack graphs repo:
- A fairly straight-forward port of the old DSL rules: https://github.com/github/stack-graphs/pull/282
- A bunch of improvements, including a grammar bump: https://github.com/github/stack-graphs/pull/358
One PR exists on the Aleph repo:
- Using the new DSL from the second PR above: https://github.com/github/aleph/pull/3306.
The main difference between old & new DSL to be aware of when making the switch is the effect of graph pruning in the old DSL. Because of the pruning, the rules didn't have to be careful about which identifiers were definitions and which weren't. Pop nodes were created for many reference identifiers, but pruning ensured they never showed up. The new DSL does not prune, so if a pop is created for a reference, it will show up as a result in the UI when clicking the reference! The second stack graphs PR does work to make the rules more precise in that regard, which is important for a good UI experience.
We should move Python over to the new DSL and remove the old DSL