search

github / stack-graphs

Rust implementation of stack graphs
https://docs.rs/stack-graphs/*/stack_graphs/
Apache License 2.0
752 stars 130 forks source link

Indexing fails abruptly for a Python codebase #418

Closed shobrook closed 5 months ago

shobrook commented 5 months ago

Hi,

I tried indexing a majority-Python codebase locally using the CLI and it failed with this error:

image

If I directly parse this file with the CLI, I get output with no errors:

image

But when I index the whole codebase, it fails on this file and stops the indexing process entirely. There appears to be no error-handling. I would have expected the indexing process to simply skip the offending line of code, or the file completely, instead of halting the indexing process.

As a result of this, I can't run queries for every file in the codebase since I'm working with only a partial index.

Any idea why this is the case? Would this behavior change if I used the API instead of the CLI?

Thank you in advance for your help!

hendrikvanantwerpen commented 5 months ago

Hi @shobrook! Thanks for reporting this. I agree this this is not ideal behavior for the CLI. I've opened a PR to fix that (#419).

shobrook commented 5 months ago

Thanks for the quick fix!