github / stale-repos

Find stale repositories in a GitHub organization.

https://github.blog/2023-06-05-announcing-the-stale-repos-action/

MIT License

123 stars 26 forks source link

feat: add repository visibility (public/private) to output #87

Closed jmeridth closed 4 months ago

jmeridth commented 4 months ago

Pull Request

Proposed Changes

Our priority was to archive public repositories that were not updated in a certain amount of inactive days. This PR adds that information to the output.

[x] update code/tests for new visibility column

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either bug, documentation, enhancement, infrastructure, or breaking

jmeridth commented 4 months ago

Looking at error

jmeridth commented 4 months ago

ok. really broke it. fixing locally and getting my linting check working locally to match remote. 😄

jmeridth commented 4 months ago

Removed the line that I forgot to remove. Now the linter (in GitHub Actions) for this line is saying the closing quote needs to be on a new line. Local syntax does not like that. I can't run make test or make lint (passes locally) without it being on line 910 to close the quoted string. 🤔 🤞 this latest run will pass. 😄

zkoppert commented 4 months ago

Teamwork! Wohoo! 🎉

jmeridth commented 4 months ago

This will be the 2nd time I've forgotten that GitHub Actions doesn't show \n, it does an actual newline. 🤦 Thank you for getting this closed out @zkoppert. 🙇

zkoppert commented 4 months ago

You've forgotten more than I knew! Haha. I had no idea that was why it did it. I just noticed the make test fail and noticed the output difference.