search

github / training.github.com

Legacy (no longer published) GitHub Training site
79 stars 46 forks source link

Missing preposition in Office Hour aftermath blurb #115

Closed randomecho closed 11 years ago

randomecho commented 11 years ago

Also going with the hyphen-less "best practices", but iffy on if "getting-started" needed that.

matthewmccullough commented 11 years ago

I'll leave it to @tlberglund to point out the correct use of hyphens or quotes on the getting-started piece and then I'll merge this :dog: with pleasure!

matthewmccullough commented 11 years ago

@tlberglund hyphen ping per above.

tlberglund commented 11 years ago

@matthewmccullough I can't identify a rule for this, but I'd have written it the way @randomecho did. And anyway, we all know how well language admits to rules, so in this case, we'll :ship: it his way. Merging. :)

ericgerhardt commented 11 years ago

In both cases what we're talking about here are compound adjectives which are generally hyphenated. As it is you've got one of them hyphenated and the other one not, which seems a little inconsistent. If it were entirely up to me, I'd hyphenate the second ("best-practices", or actually "best-practice") if only for consistency, but please go with whatever sounds best to you.

randomecho commented 11 years ago

The rule on compound adjectives fits then under the current phrasing.

It just looked a little "off" having not really seen "getting started" and "best practice" used as adjectives prior to this.