search

github / training.github.com

Legacy (no longer published) GitHub Training site
79 stars 46 forks source link

Replace all PNG icons with Octicons #169

Closed jordanmccullough closed 10 years ago

jordanmccullough commented 10 years ago

This addresses all PNG icon uses in the Non-Programmers deck only. Subsequent PRs will be provided for the other decks.

brntbeer commented 10 years ago

so happy

jordanmccullough commented 10 years ago

Still needs some styling to make the icons more prominent, but the PNGs are now replaced with Octicons.

screen shot 2013-12-18 at 10 17 02 pm screen shot 2013-12-18 at 10 16 56 pm screen shot 2013-12-18 at 10 16 49 pm

jordanmccullough commented 10 years ago

screen shot 2013-12-19 at 10 13 41 am screen shot 2013-12-19 at 10 13 37 am screen shot 2013-12-19 at 10 13 33 am

matthewmccullough commented 10 years ago

So awesome, @jordanmccullough!

jordanmccullough commented 10 years ago

@brntbeer, You want to give this one final run locally and let me know if everything checks out? Then we can :ship: this first pass.

brntbeer commented 10 years ago

one thing i noticed is that i can't actually increase the font size at all. i can decrease it but not increase. This obviously wasnt holding up the ship.

jordanmccullough commented 10 years ago

This is a RevealJS font-styling thing (body{font-size:100%}) I definitely want to address soon. Thanks for bringing that up.