search

github / twui

A framework for developing interfaces on the Mac.
Other
400 stars 79 forks source link

Added support for a TUITableView footer view #134

Closed jagreenwood closed 11 years ago

avaidyam commented 11 years ago

I've left a few comments on the PR so as to save @jspahrsummers and @jwilling some time, but this coincided perfectly with my requirements for a TUITableFooterView.... Thanks!

jagreenwood commented 11 years ago

For the most part I mimicked what was done for headerView for sake of consistency. I'll take a look at simplifying the setter. Cheers

jwilling commented 11 years ago

@jagreenwood Hey, thanks for your pull request. I agree consistency is important.

Since you're modifying the portion of the code that involves the headers and footers, it's a good time to be transitioning those over to properties with no implicit ivars and no synthesize. You've already done most of the work, so I think all that's needed at this point is simply to delete the ivars for those header and footer properties.

jwilling commented 11 years ago

Thanks for your work on this @jagreenwood. Just a couple things need to be dealt with. The first is the note I added above.

Secondly, with all new additions to the user interface it is our goal to have the demo updated to reflect those changes in some way. Is it possible you could add onto the demo to demonstrate this functionality? Thanks.

jagreenwood commented 11 years ago

@jwilling Sure thing, I'll fix these up in 2 separate commits.

jwilling commented 11 years ago

Thanks, @jagreenwood!