Remove short-paths.test.ts

robertbrignull commented 3 months ago

These tests are failing on main because the windows action image has disabled 8.3 filename creation: https://github.com/actions/runner-images/commit/5ecfd27e8fd0a1b4e8c88072772f9bbab9c82b83

I think this means we can delete handling of the entire feature from the extension, but for now I'll just delete the tests to unblock other PRs. I'll open a second PR to remove the rest of the code.

Checklist

[ ] CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
[ ] Issues have been created for any UI or other user-facing changes made by this pull request.
[ ] [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

robertbrignull commented 3 months ago

Oops, I forgot to remove the test data under extensions/ql-vscode/test/unit-tests/data/short-paths, but I'll remove those in https://github.com/github/vscode-codeql/pull/3638

robertbrignull commented 3 months ago

See https://github.com/github/vscode-codeql/pull/3643 where this PR is reverted and we fix the tests

github / vscode-codeql

Remove short-paths.test.ts #3637

Checklist