search

github / vscode-github-actions

GitHub Actions extension for VS Code
https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions
MIT License
495 stars 91 forks source link

Support GHES #12

Open nicola-lunghi opened 1 year ago

nicola-lunghi commented 1 year ago

The Github authentication plugin allows to connect to priate instances of github enterprise Please add a configuration field to allow to use private github instances

image

Thanks!

thedaviddias commented 1 year ago

@cschleiden any ETA or status on when this could be possible?

cschleiden commented 1 year ago

@thedaviddias No updates to share at this point, we are still figuring out the next set of priorities.

thedaviddias commented 1 year ago

Thank you @cschleiden!

jeffstoner commented 1 year ago

I'm about to on-board 300+ developers to GHES and would love to tell them "you can use this extension to mind your Actions activities directly in VSCode."

megamorf commented 1 year ago

I'm member of a 20000+ user GHES instance and would also love to see some prioritization of this ticket.

Olfi01 commented 1 year ago

This would also require a tiny change to the language server, which I proposed in https://github.com/actions/languageservices/pull/43, to actually show all the relevant information

Olfi01 commented 1 year ago

I implemented the necessary changes in #183, would be happy if someone could review 😄

cschleiden commented 1 year ago

x-posting my comment here:

https://github.com/github/vscode-github-actions/pull/183#issuecomment-1548246629

Thank you for this. Unfortunately for full GHES support it's not just about authenticating and making calls to the right API base url. The biggest issue to solve is versioning.

Not every customer is running the latest GHES version. And the latest released GHES version does not always support the same features as github.com. So some APIs that the extension relies on might not be available on the connected GHES version. Or the GitHub Actions workflow schema that ships with the extension does not match the features supported by the connected GHES version.

Ideally, we detect the GHES version and select the correct feature set, but this requires more work across the language services and the extension itself.

We might be able to add what you're proposing here as something that's unsupported (but still available) but that requires some more discussion.

cliffchapmanrbx commented 1 year ago

Any update on this? I can see the README now mentions it but it looks like that was a preemptive change. We have a large number of internal developers excited to use this extension with our 3.8 GHES instance.

kimisikainai commented 1 year ago

I was able to connect to GHES, but I couldn't trigger workflow, and nothing happened when I clicked. image

ragchuck commented 1 year ago

In our work environment we use GHES 3.8 and I was also able to connect, so it works... partially. I'm using this extension only to track the status of my workflows and have the syntax highlighting and completion.

There is currently an issue when retrieving organization secrets for a repository while hovering over my actions code (showing Request textDocument/hover failed or Request textDocument/completion failed.

This is because GHES 3.8 doesn't support the most recent GitHub API yet and the List repository organization secrets endpoint is not available in 3.8.

This will change with GHES 3.9:

  • REST API To provide API integrators a smooth migration path and time to update integrations after GitHub makes occasional breaking changes, the REST API now uses calendar-based versioning. GitHub Enterprise Server 3.9 provides version 2022-11-28 of the REST API. For more information, see "API Versions" in the REST API documentation.

Maybe this helps.

mostafakn commented 11 months ago

The Github authentication plugin allows to connect to priate instances of github enterprise Please add a configuration field to allow to use private github instances

image

Thanks!

NiceNicr commented 8 months ago

https://github.com/github/vscode-github-actions/issues/12#issuecomment-1825217768

NiceNicr commented 8 months ago

https://github.com/github/vscode-github-actions/issues/12#issuecomment-1825217768

jb-2020 commented 6 months ago

One note, after enabling GHES support, the actions that are sourced from our enterprise server are still linking to github.com when clicking Open action on GitHub in a workflow. I think if GHES is enabled then all of the Open action on GitHub buttons should also link to the configured instance of GHES.

jwilkicki commented 5 months ago

One note, after enabling GHES support, the actions that are sourced from our enterprise server are still linking to github.com when clicking Open action on GitHub in a workflow. I think if GHES is enabled then all of the Open action on GitHub buttons should also link to the configured instance of GHES.

The same problem exists referencing reusable workflows. They reference github.com instead of our GHES instance.