github / webauthn-json

🔏 A small WebAuthn API wrapper that translates to/from pure JSON using base64url.
https://github.github.com/webauthn-json/demo/
MIT License
757 stars 60 forks source link

Browser-global extended distribution variant missing #61

Closed j-hellenberg closed 2 years ago

j-hellenberg commented 2 years ago

Hi all,

during a recent project we wanted to use the browser-global dist version but noticed it is only exported in the basic and not the extended variant. Therefore, we'd like to ask whether you would be interested in adding that version to the script/build-js.js. As we've already done that in our fork to get our project to work, I've also just submitted a small PR (#60) for that in case you want to take a look :slightly_smiling_face:

lgarron commented 2 years ago

Hi! Thanks for offering the contribution!

I'd really like to keep the scope of this project as small as possible, which includes avoiding new builds if possible.

Speaking as the primary maintainer, I'm reluctant to offer the extended build a browser-global version because:

I hope it's okay if I decline the PR for now, but I'm happy to reconsider if we get more requests for this.

To that end:

j-hellenberg commented 2 years ago

I think that's some pretty good reasoning you came up with there.

Regarding your question about why we wanted to do this, I must admit it was mostly about convenience. We were doing a research project and used the library for our proof-of-concept implementation which required some of the extensions, mainly the largeBlob extension (the profile page of the organisation we created for the project provides a very brief summary on the topic in case you're interested). Therefore, while we could probably have made it work using the module build with a bit more effort (or maybe a bit more experience on using modules in a non-module context, for that matter), we decided to go with the just-plug-it-into-a-script-tag-and-use-it-everywhere solution for our prototype.

Obviously, if we wanted to turn that prototype into a more fully-fledged solution, we'd put more attention to actually following conventions. Therefore, we're fully fine with you declining the proposal. We just wanted to bring it up in case it was missing due to an oversight instead of a conscious decision :slightly_smiling_face: