search

github / webpack-bundlesize-compare-action

A github action that outputs bundlesize comparison tables for pull requests
MIT License
78 stars 19 forks source link

Switch comment header to an h3 #443

Closed j-f1 closed 1 year ago

j-f1 commented 1 year ago

The h1 header is very loud in the comment section at the moment. Netlify’s auto comments use an h3 instead of an h1 and it still draws attention without being too annoying.

shiftkey commented 1 year ago

Thanks for the contribution @j-f1. I'm going to leave this open for a bit to figure out why the test suite isn't passing (failures are highly likely to be unrelated to your change).

j-f1 commented 1 year ago

It looks like since my PR comes from a fork the action isn’t allowed to post a comment. I encountered a very similar issue when integrating the check into a repo I help maintain and ended up swapping the workflow to a pull_request_target trigger but that wouldn’t work here since you presumably want to test any code changes.

shiftkey commented 1 year ago

Looks like this PR only has read access to pull requests, likely due to it coming from a fork as you mentioned.

These permissions seem fine though, perhaps we could run these jobs with a token that does have access to comment here (rather than jumping through all these GITHUB_TOKEN hoops):

https://github.com/github/webpack-bundlesize-compare-action/blob/96f0bebee0c9c1cb7f116b88dfe0169f656ca7a1/.github/workflows/test.yml#L10-L12

shiftkey commented 1 year ago

Merging this in for now as I see #431 will also have the same issue