Closed j-f1 closed 1 year ago
Thanks for the contribution @j-f1. I'm going to leave this open for a bit to figure out why the test suite isn't passing (failures are highly likely to be unrelated to your change).
It looks like since my PR comes from a fork the action isn’t allowed to post a comment. I encountered a very similar issue when integrating the check into a repo I help maintain and ended up swapping the workflow to a pull_request_target
trigger but that wouldn’t work here since you presumably want to test any code changes.
Looks like this PR only has read
access to pull requests, likely due to it coming from a fork as you mentioned.
These permissions seem fine though, perhaps we could run these jobs with a token that does have access to comment here (rather than jumping through all these GITHUB_TOKEN
hoops):
Merging this in for now as I see #431 will also have the same issue
The h1 header is very loud in the comment section at the moment. Netlify’s auto comments use an h3 instead of an h1 and it still draws attention without being too annoying.