github201407 / contactlistimporter

Automatically exported from code.google.com/p/contactlistimporter
1 stars 0 forks source link

Some contacts do not have name or email address in YahooMail Importer #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Run mvn package
2.
3.

What is the expected output? What do you see instead?

I see some contacts do not have name or email address in following result:

Testing importer: com.xdatasystem.contactsimporter.yahoo.YahooImporter
Jun 1, 2008 4:28:42 AM
com.xdatasystem.contactsimporter.ContactListImporterImpl getContactList
INFO: Performing login
Jun 1, 2008 4:28:46 AM
com.xdatasystem.contactsimporter.ContactListImporterImpl getContactList
INFO: Login succeeded
Jun 1, 2008 4:28:46 AM
com.xdatasystem.contactsimporter.ContactListImporterImpl getAndParseContacts
INFO: Retrieving contactlist
Jun 1, 2008 4:28:48 AM
com.xdatasystem.contactsimporter.ContactListImporterImpl getAndParseContacts
INFO: Parsing contactlist
name: °º¤ø,¸¸,ø¤º°  okie (), email: 
name: Ai Van   (), email: 
name: Ai Van  Nguyen Ngoc (AiVan), email: nguyenngocaivan@yahoo.com
name: Anh  Chien (), email: 
name: Anh  Tu (), email: 
name:    (), email: 
name:    (), email: 
name: babycat   (), email: 
name:    (), email: 
name:    (), email: 
name: bo^' Va^n An   (), email: 
name: CAM HA  NGO THI (), email: ngothicamha@yahoo.com
name: camha2911   (), email: 
name: chi Hanh   (), email: 
name: Chien  Tran Thi (chi Chien), email: 
name: Cuong  khung (), email: 
name:    (), email: 
name: Dao Cam Le   (), email: 
name: Dat Ma   (), email: 
name: Diem  Le Ngoc (Diem), email: 
name: dieu   (dieu), email: thuydieu1010@yahoo.com
name: Dinh Phi   (), email: mtdinhphi@yahoo.com
...

What version of the product are you using? On what operating system?
lastest source code on SVN (May 22, 2008)

Please provide any additional information below.

Original issue reported on code.google.com by Tai.Nguy...@gmail.com on 31 May 2008 at 9:45

GoogleCodeExporter commented 8 years ago
I have changed following line from:
    email = entry[4];

to:

if (!"".equals(entry[4])) {
    email = entry[4];
} else {
    if (!"".equals(entry[7])) {
        email = entry[7] + "@yahoo.com";
    } else {
        email = "";
    }
}

in method parseContacts() of class YahooImporter.

Original comment by Tai.Nguy...@gmail.com on 1 Jun 2008 at 2:04

GoogleCodeExporter commented 8 years ago
Thank you for your bug fix, i will try to put it in the repository if i have 
time.

Original comment by tje...@gmail.com on 5 Jun 2008 at 9:08

GoogleCodeExporter commented 8 years ago
fixed in revision 17

Original comment by tje...@gmail.com on 19 Aug 2008 at 9:40