search

githubDante / deye-controller

DEYE Hybrid inverters library
MIT License
38 stars 7 forks source link

Why max charge/discharge power is limited to 185A ? #17

Open toruonu opened 3 weeks ago

toruonu commented 3 weeks ago 
""" Charge / Discharge """
MaxChargeAmps = IntWritable(address=108, low_limit=0, high_limit=185)
MaxDischargeAmps = IntWritable(address=109, low_limit=0, high_limit=185)

I'm curious why they are limited to 185? According to spec the SUN-12K-SG04LP3-EU (same as tested with, I have) has a max charge/discharge power of 240A. Should I just modify the code or is there a good reason for this?

Also as listed in another issue someone already found the sell mode register, maybe this upping to 240 and the new register could be added together to the next release or is it safe to just add myself :)

githubDante commented 3 weeks ago

The limits are set according to the MODBUS documentation. It's available in the docs dir. The limits can be overwritten quite easily either through the _high attribute or by using a custom register.

Register 142 will be included in the next version.