githubbob42 / mingle2github2

0 stars 1 forks source link

Make all "add-item" code paths validate before adding #2640

Open githubbob42 opened 5 years ago

githubbob42 commented 5 years ago

Mingle Card: 2918 The rules engine will introduce new code paths to trigger new add items to be added to a ticket. To ensure that items created will sync without error, we need to validate the items prior to adding them.

Analysis

The `TicketItemWizard` module provides this functionality to the application and is currently used by the `TicketItemPicker` module (used when the user picks price book items to add). We should wire up the other "add-item" code paths to use the `TicketItemWizard` module also.

The identified "add-item" code paths are:

When implementing the new rules engine for card #2879, we'll also want to use the `TicketItemWizard` module to ensure that all items created are validated.

githubbob42 commented 5 years ago

Story: #2602 Simple Required Items (Mingle)