githubbob42 / mingle2github2

0 stars 1 forks source link

Quote Sync making too many describe calls #3482

Closed githubbob42 closed 8 years ago

githubbob42 commented 8 years ago

Mingle Card: 3795 Steps to reproduce

| | |
|-|-|
  1. Make sure there are some eforms declared
  2. Sync on Mobile with DevTools network tab open
  3. Filter on Describe calls

Expected result

There should not be a v34 call for Ticket Checklist Step

Actual Result

There are a whole bunch of extras describe calls.  The calls in and of themselves are not harmful, but they do add a lot of extra calls to the sync.

Analysis

The error is in the new sync/blacklist module in describeChildFxForms.  In the original whitelist code from alpine server, it would only go one level deep and only traverse master-detail relationships.  The code we currently have does not do either of those.  So it traverses very deep and adds a lot of stuff to the blacklist we don’t care about.

This is masking another problem.  The primary of list of blacklisted items is not being scanned for their lookups.

Related Cards

Test Plan

Checklist for Merging

githubbob42 commented 8 years ago

Related Story: #3411 Sync Quote Lookup Data to Mobile (Mingle)