Job/Quote HTML Reports don't sync back to Mobile

githubbob42 commented 7 years ago

Mingle Card: 4481 I think Maurya made this change for Tickets last year? Look for the ticket card.

MR – Based the several user stories around fetching attachments(report templates and report attachments), as well as how report attachments are stored/viewed, the changes to support quotes should be extremely minimal. May also bring down job html reports also if the change is as minimal as expected.

Change is minimal: add quote and job to supported parents: ex:

var attachmentTypes = parent && parent.referenceTo.filter(function(type) {
return new RegExp('^(\\w+__)?(report_template|ticket|quote|job)(__c)?$','i').test(type);
});

Steps to Reproduce

| | |
|-|-|
|**Version #**|

FieldFX() 4.0.1.3352on 3.5.5

Beta Bi-Weekly on ~3.5.5

   |
|**Hardware**| |
|**OS**|Windows|
|**Browser**|WindowsChrome53.0.2785.116|
|**Username**|wir\_test\_so@pioneeres.com.fsb|
|**Password**|Use LastPass|
|ORG ID| |
|User ID| |
|RayGun Error ID| |

Synopsis: At the ticket level when you render an HTML Report in Mobile that HTML Report keeps syncing down to mobile. On the quote currently the HTML report does not come back to mobile and to the best of my knowledge there is not a way for me to get the HTML Report to to sync back to mobile.

T

Login to Mobile
Create a quote
Render and save a Quote HTML.
Sync twice the HTML report falls off the mobile device.
There is not a way to have the Quote HTML to sync back to the device for the users to verify Signature and other information of the quote at the time the The quote was originaly Signed

Expected Result

Quote HTML reports should sync the same way old quoting did IE how tickets currently do

Actual Result

The HTML reports to dont sync back to mobile

Analysis.

This was only done for ticket reports. Job Reports doesn’t follow this pattern. A good solution will support this feature for all 3(Tickets, jobs, and Quotes), and maybe even eforms.

We’ll want to plan this feature along with card #4427 to allow for a broad solution that works with all of reporting and avoid cases where we exceed web storage limits. This include utilizing cache storage when available.

At the moment, we only fetch down attachments associated with tickets that are synced down to mobile. Report Attachments are stored in the standard attachments table. Unlike other objects that we sync down, attachments are not bound by sharing rules. Rather they’re bound by the sharing rules of it’s parents. To avoid fetching all attachments for all objects that users have permission to, it was decided for now to only support job, quote, ticket, with a future story to support eforms.

We need to add support for fetching down the attachments via the new sync. Some of the steps taken to get this to work are:

Add Attachments to the whitelist lookup
Add an attachment entry in the cache module
Add a handler(very similar to static resources) to intercept attachments, and for every report, store the report body into cache storage.
in soql-builder, add 2 predicates to limit the number of attachments being fetched down. predicate 1 to filter out all report templates not of type html. predicate 2 to only fetch down attachments with a parent of job, ticket, or quote
in schema.js, add a check for attachments and user the reference’s namespace to help create the index for fetching attachments via it’s Parent object Id.

TODO:

Have report list to fetch attachments synced from salesforce from sobjects store
Have report viewer fetch report body from cache storage that was synced from salesforce
support adding attachemnt to a quote that was created in mobile not synced up to salesforce. (No custom field allowed on the Attachments object).

Related Cards

Test Plan

githubbob42 commented 7 years ago

Matthew Todd : 01/20/2017 10:03 CST Test Result: Passed PR Build: 4.0.1.pr2223 Admin User: qaadmin@test4.com Field User: qafield@test4.com Hardware: Surface Pro 3 OS: Windows 10 Pro Browser: Chrome 55.0.2883.87 m (64-bit) URL: https://hunterpeak.herokuapp.com Test Case: Create a Quote Report (4481) Test Notes: The reports that are added to a Job or Quote in Mobile are kept on that object after a double-sync and don't disappear into the nether.

githubbob42 commented 7 years ago

Pull Request #2223

githubbob42 / mingle2github2