search

githubbob42 / mingle2github2

0 stars 1 forks source link

Duplicate child eForms shown on the screen #4614

Closed githubbob42 closed 7 years ago

githubbob42 commented 7 years ago

Mingle Card: 4957 Steps to Reproduce

| | |
|-|-|
|**Version #**|3641|
|**Hardware**| |
|**OS**| |
|**Browser**| |
|**Username**|npfield@soasta1.com|
|**Password**|computer46|
|ORG ID| |
|User ID| |
|RayGun Error ID| |
  1. login to Mobile
  2. create a new job and parent eform eForm RT1
  3. add few child eforms with different record types (ChildForm Job RT1 and ChildForm Job RT2)

Expected Result

forms added correctly

Actual Result

sometimes there are double or triple entries on child eForms with identical SyncID
i you leave the screen and then come back extra copies of child eForms disappear from the screen.

Analysis

The `viewmodels/children` middleware isn’t being disposed the same number of times it’s activated. This leaves “zombie” event listeners around, causing event handling to be doubled up. I think the disposal issues are caused by us asking durandal to route the the list screen twice (thereby causing it to be bound multiple times).

Related Cards

Test Plan

githubbob42 commented 7 years ago

Pull Request #2302