Duplicate (4) eForms events created in a packet

[githubbob42]

Mingle Card: 5159 Steps to Reproduce

| | |
|-|-|
|**Version #**| |
|**Hardware**| |
|**OS**| |
|**Browser**| |
|**Username**| |
|**Password**|Use LastPass|
|ORG ID|AMI|
|User ID| |
|RayGun Error ID|http://support.liquidframeworks.com/helpdesk/tickets/3070|

1. Goto fxForms tab (Job or Ticket)
2. click add new button
3. fill in any required fields and DOUBLE click add button as fast as you can

Expected Result

Only one event should be created.

Actual Result

Four duplicate events where created for a single fxForm created event (AL-49743):

https://fieldfx-7043.cloudforce.com/a0l1N000007LOQV?srPos=0&srKp=a0l

!card5159.png!

Analysis

I was able to reproduce this by double clicking on the add button and it created two duplicate events with the same Sync IDs.

I noticed that we are already using the “command” handler, which is supposed to block the UI when you click, but it doesn’t appear to be fast enough. 

• I was able to get around it by setting an “addinProgress” variable in the “attach” method but it would be nice to have a global solution, if possible.
• A better solution is to add a debounce to the command binding clickHandler that would prevent it from getting called twice and that will would work everywhere we use the command binding.

I also found that the addChild button on the fxForms parent page was not wrapped in the command binding and allowed multiple clicks and thus multiple modals to open.

Related Cards

NOTE: This fix may fix several other duplicate event issues we’ve been having...

Test Plan

See note below about CPU throttling. Try to double click when creating different objects. Make sure that your sync upload works.

The full selenium suite is green.

(Not required but throttling the CPU x2 if using the desktop helps)

• Goto fxForms tab
• click add new button
• fill in any required fields and DOUBLE click add button
• check the eventstore database in dev tools
  • look at the last 4 events 
  • if you were quick enough, it produced multiple events (2 mixpanel:FXFormCreated events and 2 model:event-queued events with the same syncId)

To test the add child form, it’s basically same as above, but get clicky on the child form add button.

NOTE:

The command binding is used on the following pages:

/bindings/report.js:

• Add report button

/fx-forms/add.html:

• Open child add window

/fx-forms/create.html:

• Create/attach child fxForm button

/fx-forms/templates.html:

• Create/attach fxForm button

/job/copy.html:

• Job copy button

/job/create.html:

• Job create button

/quote/copy.html:

• Quote copy button

/quote/create-job.html:

• Create Job from Quote button

/quote/create.html:

• Create Quote button

/quote/item/picker.html:

• Add items to quote button

/ticket/copy.html:

• Copy Ticket button

/ticket/create.html:

• Create Ticket button

/ticket/item/list.html:

• Open ticket item picker button

/ticket/item/picker.html:

• Add items to ticket button

[githubbob42]

Godswill : 06/28/2017 09:34 CDT Test Result: Passed PR Build: 4.0.1.pr2432 Admin User: godswillfield@test4.com/computer#4 Hardware: MacBook Pro OS: MacOS 10.12.5 Browser: Version 58.0.3029.110 (64-bit) URL: https://hunterpeak.herokuapp.com Test Case: Steps on 5159 Test Notes:Duplicate eform event is no longer created in the event store

[githubbob42]

Pull Request #2432