githubbob42 / mingle2github2

0 stars 1 forks source link

TECH DEBT: return promise from form.populateRaw() calls #5566

Open githubbob42 opened 5 years ago

githubbob42 commented 5 years ago

Mingle Card: 5928 Steps to Reproduce

| | |
|-|-|
|**Version #**| |
|**Hardware**| |
|**OS**| |
|**Browser**| |
|**Username**| |
|**Password**|Use LastPass|
|ORG ID| |
|User ID| |
|RayGun Error ID| |
  1. Do this
  2. Then do that
  3. Followed by this

Expected Result

What should happen?

Actual Result

What actually happens?

Analysis

After working on card #5927, I found that we were not returning nor chaining off of the form.populateRaw() call in several places.  This was a problem for the workflow.js module.  Although everything appears to be ok, we should be doing the same for all calls to form.populateRaw()

Turns out this is not so much of a problem and actually causes more problems by returning the promise instead of the object itself.

Related Cards

[alpine_mobile/#5927] Quick Reports allow you to add a Report even if status "preventReport" is true

Test Plan

| | |
|-|-|

1.

   |

Ensure the card has enough information from the programmer before you start the verification

If not request more information

   |

   |

2.

   |

Ensure you’re able to reproduce the defect prior to verifying it

   |

   |

3.

   |

Ensure to verify if the PR is still valid by going to Github.

   |

   |

3.

   |

Create a test plan and write/update test case for the card is there is no test case in Tarantula.

   |

   |

4

   |

Test the card on all required devices and versions. If it’s a mobile card, always test the offline functionality around that defect. Attach screenshots to the card as necessary displaying the fix

   |

   |

5.

   |

Add the following test result documentations:

    *   Test Status:
    *   PR Build:
    *   Username/Password
    *   Test case name:
    *   Environment and devices tested on:
    *   Test Note.

   |

   |

6.

   |

Push the card to “Testing Complete”

   |

   |