githubbob42 / mingle2github2

0 stars 1 forks source link

RayGun t.GetDirtyProperties is not a function #5752

Open githubbob42 opened 5 years ago

githubbob42 commented 5 years ago

Mingle Card: 6117 Steps to Reproduce

| | |
|-|-|
|**Version #**|[4.0.1.4208](https://app.raygun.io/deployments/pianhu/findbyversion?version=4.0.1.4208)|
|**Hardware**| |
|**OS**|Android 6.0.1|
|**Browser**|Chrome 50.0.2661.89|
|**Username**|kcwestman@sesdriver.com|
|**Password**|Use LastPass|
|ORG ID| |
|User ID|00544000008iRSiAAM|
|RayGun Error ID|[37132723666](https://app.raygun.io/crashreporting/pianhu/errors/2289727050?dateFrom=2018-11-23T17%3A26%3A00.000Z&dateTo=2018-11-30T17%3A26%3A42.000Z#37132723666)|
  1. navigate to tickets
  2. opened a ticket with no reports attached
  3. click the items tab
  4. click the reports tab
  5. select report “DISPOSAL FEE-FLOWBACK WATER - NO CHARGE”
  6. click add button
  7. close the add report modal
  8. open a ticket item
  9. click on navigated back button (3 times)
  10. close the ticket item modal

Expected Result

The ticket item modal should close.

Actual Result

The ticket item modal stays open.

Analysis

We need to make sure we close the ticket item modal if the browser back button is pressed.

!clip-2106-8fec.png!

Proposed solution:

Add a check on deactivate to close modal instance in the view for:

This card is a duplicate. see [alpine_mobile/#6120] Message: t.GetDirtyProperties is not a function

Related Cards

[alpine_mobile/#6122] close opened modal on back button pressed

Impact Analysis

Developers: Fill in this area during code review.

Test Plan

See “steps to reproduce” for testing.

githubbob42 commented 5 years ago

Jeffry Tupa : 12/05/2018 09:27 CST duplicate: [alpine_mobile/#6120] Message: t.GetDirtyProperties is not a function

githubbob42 commented 5 years ago

Jeffry Tupa : 12/03/2018 15:04 CST This defect card is to only fix the type error being thrown. We need a new card if we want to address closing opened dialogs on navigation back.

githubbob42 commented 5 years ago

Pull Request #2991