search

githubbob42 / mingle2github2

0 stars 1 forks source link

Sync button on mobile turns grey and stays grey after reconnecting #5847

Closed githubbob42 closed 5 years ago

githubbob42 commented 5 years ago

Mingle Card: 6213 Steps to Reproduce

| | |
|-|-|
|**Version #**|4.0.1.4303|
|**Hardware**|laptop    |
|**OS**|widnows 10|
|**Browser**|chrome 72|
|**Username**|testaccount@keyenergy.com.fullsandbx|
|**Password**|Use LastPass|
|ORG ID| |
|User ID| |
|RayGun Error ID| |
  1. log into FieldFX mobile app
  2. disconnect network connection
  3. walk away from your machine for 1.5 hours
  4. return to machine and connect via mobile hotspot
  5. maximize the FieldFX app page (you should see that the sync button is grey, even though you haven’t performed a sync and you are connected)

Expected Result

application should recognize that the machine has gained network connection. Sync button should be blue and if pressed,should perform an incremental sync.

Actual Result

Sync button stays grey indefinitely.

Analysis

Card “[alpine_mobile/#6191]” commit 67a815b broke the reconnect check logic when the reconnect value was changed from a boolean to an object.

Proposed solution: 

Related Cards

Impact Analysis

No impact

​

Test Plan

Test the state of the sync button by

Initial Test Result: Reject
 

Mobile PR: 3087

User: lanrefield@seven.com   /  lastpass

Hardware: Dell XPS PC, IPAD Pro.

OS: Windows 10 & IOS 11

Browser: Chrome & Safari 

 
https://dev.fieldfx.com/

 

Test Case: iOS10:App works w/o internet connection, can be loaded from cache, proper error msg shown when internet connection interrupted and other devices

https://lfw.testrail.io/index.php?/cases/view/10195

https://lfw.testrail.io/index.php?/cases/view/6918

https://lfw.testrail.io/index.php?/cases/view/10197

https://lfw.testrail.io/index.php?/cases/view/13448

Test Notes:

I was able to reproduce the issue on 4303.

However i was not able to verify the fix because the app still does not recover the sync button

when i switch from one network to another on windows chrome.

!Capture77-855c1e.JPG!{height: 517px; width: 950px;}

Secondary Test Result: Pass

 

Mobile PR: 3087

I was able to verify the fix after re-testing. The app now recovers and the sync button goes blue when the network is changed. I performed the test on multple devices and different time intervals and it all passed.

!Capture500-699abb.JPG!{height: 579px; width: 980px;}

githubbob42 commented 5 years ago

Pull Request #3087