search

githubdoe / DFTFringe

DFTFringe Telescope Mirror interferometry analysis Program.
GNU General Public License v3.0
168 stars 59 forks source link

Annulus #123

Closed githubdoe closed 9 months ago

githubdoe commented 9 months ago

All annulus code seems to be working as desired.

gr5 commented 9 months ago

Dale, somehow I missed it but it's failing to link because zapm() isn't in the .pro file. Do you want to fix it or should I? I think if I fix it, then push the change, I can still approve the PR.

gr5 commented 9 months ago

@atsju - help! It builds but it's failing the "make-release" action. Something about "tools". Can you help us?

atsju commented 9 months ago

@atsju - help! It builds but it's failing the "make-release" action. Something about "tools". Can you help us?

I'm having a look

gr5 commented 9 months ago

@atsju - Dale emailed me back and prefers for you to make the changes. The ones that fix the compiler warnings. I assume you'll do it in #125 and I should close 123 at some point.

gr5 commented 9 months ago

closed for now - don't want someone to merge this one by mistake.

atsju commented 9 months ago

Does this close #30 and #119 ?