Fix loop that never returns on http error

githubexporter / github-exporter

:octocat: Prometheus exporter for github metrics

MIT License

425 stars 121 forks source link

Closed jcreixell closed 1 year ago

jcreixell commented 1 year ago

While running this exporter in the grafana agent, we have identified a loop that never returns in case of http error. This in turn causes the agent to never release a lock, preventing it from making progress.
Note: I have not added additional metrics to report errors as I am trying to keep the scope of this change minimal, but it would be a good idea to add a gauge as stated in the prometheus guidelines.
See https://github.com/grafana/agent/issues/3144

henrymcconville commented 1 year ago

Thanks for this @jcreixell and sorry for the delay in getting this merged.

This is now available as version 1.0.4 and on Docker Hub at githubexporter/github-exporter.