Add polling-style file watch option

githubnemo / CompileDaemon

Very simple compile daemon for Go

BSD 2-Clause "Simplified" License

1.61k stars 153 forks source link

Add polling-style file watch option #53

Closed HurSungYun closed 3 years ago

HurSungYun commented 3 years ago

As discussed in #44 and #47, file watch via fsnotify is troublesome in some Mac OS X or Docker environment.

So, I implemented optional polling-style file watch mechanism to avoid horrible file system issues as suggested in #44.

It still has optional parameter to choose either polling or fsevent, so non-OS X user won't be affected by this change.

githubnemo commented 3 years ago

Thanks a lot! The changes are well implemented and I can see them being useful to workaround the issues around Docker on Mac OS X and Windows bind mounts.

HurSungYun commented 3 years ago

thank you for your thoughtful reviews :)