githubnemo / CompileDaemon

Very simple compile daemon for Go
BSD 2-Clause "Simplified" License
1.61k stars 153 forks source link

Bump fsnotify to bump sys for go1.18 #76

Open ypresto opened 2 years ago

ypresto commented 2 years ago

I'm using go 1.18 on macOS, and go install fails with below message:

$ go install github.com/githubnemo/CompileDaemon@latest
# golang.org/x/sys/unix
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../go/1.18.0/pkg/mod/golang.org/x/sys@v0.0.0-20191026070338-33540a1f6037/unix/zsyscall_darwin_amd64.go:121:3: too many errors

This is caused by old x/sys library.

Using depth dependency tree visualizer, I found old fsnotify module references old x/sys module.

So just I bumped it :)

sylr commented 2 years ago

https://github.com/bwplotka/bingo test suite on MacOS / go1.18 does not work anymore because of this.

We would appreciate if this could be merged and released promptly :)

Thanks.

Needed for https://github.com/bwplotka/bingo/pull/109

jeffreydwalter commented 2 years ago

@githubnemo can you please merge this?

ypresto commented 2 years ago

I created fork at https://github.com/ypresto/CompileDaemon/tree/bump-sys . You can install it by below snippet:

go get github.com/ypresto/CompileDaemon@bump-sys-fork
nhatthm commented 2 years ago

Bump.

patrickvalle commented 1 year ago

@githubnemo Any chance this can get merged soon?