githubnemo / CompileDaemon

Very simple compile daemon for Go
BSD 2-Clause "Simplified" License
1.61k stars 153 forks source link

CompileDeamon not found golang 1.18 #77

Open valensto opened 2 years ago

valensto commented 2 years ago

Hi,

Cannot run CompileDeamon as Entrypoint of dockerfile with golang 1.18 Working on golang:1.17.8-alpine3.15 with same ENTRYPOINT

tested with go get github.com/githubnemo/CompileDaemon@latest

Denes-cilwal commented 2 years ago

@valensto I faced same issue when i updated golang to 1.18 the reason is golang:1.17.8-alpine came with the git executable - presumably to accommodate go get - but golang:1.18-alpine does not - presumably because of the breaking change to go get that accompanied the new version.

go install github.com/githubnemo/CompileDaemon@latest also add RUN apk add --no-cache git to dockerfile

diegoclair commented 2 years ago

I'm with same error with golang:1.18

Denes-cilwal commented 2 years ago

I'm with same error with golang:1.18

go install github.com/githubnemo/CompileDaemon@latest also add RUN apk add --no-cache git to dockerfile go 1.18 no longer supports go get , you need go install did this solve your error ?

mr1hm commented 2 years ago

@Denes-cilwal i was experiencing the same issue and can confirm replacing "go get" with "go install" fixed it for me

diegoclair commented 2 years ago

@Denes-cilwal thanks for the answer. With golang:1.18 it worked adding: RUN apt-get install git and go install github.com/githubnemo/CompileDaemon@latest

With golang:1.18-alpine I got the follwing error when it starts to build the application: error obtaining VCS status: exit status 128 Use -buildvcs=false to disable VCS stamping.

But thats ok, I'm not using alpine for my tests here. Thanks again

UPDATE: I tested the image golang:1.18 without RUN apt-get install git and it worked too o//

Denes-cilwal commented 2 years ago

I see thanks for your update 👍🏾

spaiki007 commented 1 year ago

example

main repo - sub app repo <- I got it here, Use -buildvcs=false to disable VCS stamping. - ...

Decision

` FROM golang:alpine

WORKDIR /go/src/app

ENV GOFLAGS="-buildvcs=false" <- it helped!

COPY go.mod go.sum ./

RUN go mod download && go mod verify

RUN go install github.com/githubnemo/CompileDaemon@latest

CMD ["CompileDaemon", "-command=./app"]

`

Shiba-Kar commented 1 year ago

go 1.20.6

Screenshot 2023-07-23 at 1 09 43 PM
valensto commented 1 year ago

@Shiba-Kar first, did you restart your terminal? ☺️

Shiba-Kar commented 1 year ago

@Shiba-Kar first, did you restart your terminal? ☺️

Yes done a reboot