search

githubnext / blocks-template

A template for creating custom Blocks.
MIT License
112 stars 11 forks source link

feat: add toast notifications for callbacks #13

Closed Wattenberger closed 2 years ago

Wattenberger commented 2 years ago

image

irealva commented 2 years ago

Do the callbacks show up in the blocks prototype? If not, i'd suggest just a minor text change along the lines of: "Dev warning - callback triggered" or something like that to make it clear it won't show up in prod.

Wattenberger commented 2 years ago

@irealva it kind of says that in the note at the bottom, but could be more explicit! maybe:

These callbacks aren't implemented in testing environments, but will work on blocks.githubnext.com instead of showing a popup

irealva commented 2 years ago

@irealva it kind of says that in the note at the bottom, but could be more explicit! maybe:

These callbacks aren't implemented in testing environments, but will work on blocks.githubnext.com instead of showing a popup

ooh you right you right. Think I missed it bc it was small on the PR. I think what you have is fine!