search

githubnext / blocks-template

A template for creating custom Blocks.
MIT License
112 stars 11 forks source link

Add function component names #50

Closed karlhorky closed 1 year ago

karlhorky commented 1 year ago

First of all, thanks for GitHub Blocks, really cool! I still need to internalize the idea behind the concept to think about all of the possibilities that they enable (and also try to find out when they will be available for everyone as a part of github.com), but I sense that they are powerful and will enable new experiences in viewing and interacting with files which have been (mostly) static up until now.

Just a small PR: For better debuggability and to align with idiomatic React, add names to the function components.

cc @Wattenberger @mattrothenberg since you have been most active in these files

Wattenberger commented 1 year ago

great call, thanks for the PR! Would love to see you around the Discord, if you aren't already https://discord.gg/githubnext

karlhorky commented 1 year ago

Glad to help, thanks for the quick review and merge!

Would love to see you around the Discord, if you aren't already discord.gg/githubnext

Just joined and sent you a note over there, thanks! (I'm karlhorky#6875)