githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.15k stars 219 forks source link

Some ligatures render in VSCode as a single letter stop #115

Closed iansan5653 closed 2 months ago

iansan5653 commented 7 months ago

Please forgive my ignorance in describing this issue. I am not very familiar with font tech and I'm not even 100% sure this is a Monaspace bug and not a VSCode bug. But I think it's Monaspace because it doesn't happen with other fonts.

The problem is that some ligatures (I've noticed -> and =>) register in VSCode as a single big character. This means the cursor can't go in the middle of them, resulting in a very confusing typing experience where the active cursor jumps around:

https://github.com/githubnext/monaspace/assets/2294248/fefcb65a-e868-42cb-ba25-2a118c28800b

Strangely, this doesn't always happen, like when I'm in a comment:

https://github.com/githubnext/monaspace/assets/2294248/ab7127ac-b4f7-4767-896d-8829ab25b0eb

iansan5653 commented 7 months ago

I noticed this also happens with </> which is super confusing when closing JSX, particularly since it's three characters long:

https://github.com/githubnext/monaspace/assets/2294248/139c503d-a628-4da9-a852-fa052ed2f0d8

Finii commented 7 months ago

This is one result to the way the ligatures are formulated, see bottom part of #132 for an explanation.

idan commented 2 months ago

Fixed in ca8015b27bdc6d8e1201b1ad722f4ae3c38970d0