githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.14k stars 219 forks source link

Request to Revise 'dlig' Recommendation in VS Code fontLigatures Sample for Monaspace to Prevent Display Issues with Japanese Text #152

Open 74th opened 7 months ago

74th commented 7 months ago

Hello.

I would like to bring to your attention a display issue in Visual Studio Code that arises from the 'dlig' ligature setting suggested in the Monaspace font documentation. This setting interferes with the display of the Japanese characters 'ます'—a part of a commonly used word akin to the polite form of 'is' in English—when used in conjunction with the Hiragino font, which is a standard font for Japanese text on macOS.

スクリーンショット 2023-11-23 20 37 05 スクリーンショット 2023-11-23 20 37 16

The recommendation to use 'dlig' in the editor.fontLigatures setting can inadvertently cause display problems for users who edit Japanese text. While the Monaspace font works well, the issue appears to be specific to the interaction between 'dlig' and certain Japanese fonts like Hiragino.

To avoid this issue for users who work with Japanese scripts, I propose that the editor.fontLigatures sample configuration in the Monaspace documentation be revised to either remove 'dlig' or include a warning about its potential effects on non-Latin scripts, particularly with widely used Japanese fonts on macOS systems.

Steps to Reproduce:

  1. Include 'dlig' in the editor.fontLigatures as per the current Monaspace documentation.
  2. Use VS Code to type the Japanese characters 'ます'.

Expected Result: The 'ます' characters should be rendered correctly, given their frequent use in Japanese language texts.

Actual Result: The 'ます' characters disappear from the editor when 'dlig' is active in the editor.fontLigatures setting.

Screenshots demonstrating the settings and the issue in VS Code are attached. Updating the documentation to address this nuance would greatly assist in ensuring a smooth experience for Monaspace users working with Japanese text.

Thank you for considering this request.

skytomo221 commented 6 months ago

This issue is also reproduced on Windows. Also, it should be kept in mind that this problem also applies to kumimoji—a block of multiple characters arranged in a space equivalent to that of a single character (an imaginary square), usually containing katakana, used as way of abbreviation.

この問題は、最初に 74th さんにより報告されました。Windowsでも再現します。 また、この問題は、「ます」以外にも組文字にも同様の問題があるコトに留意する必要があります。 日本語リテラルがこのように意図せず合字になってしまうケースはホントに困ります。

For example, the above text will be displayed as follows.

image image