search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.12k stars 219 forks source link

#185 Update Linux install script to refer to the correct relative paths #186

Closed brunofin closed 1 month ago

brunofin commented 4 months ago

Modify script so it works with the instructions provided in README.

Closes #185

brunofin commented 4 months ago

@barnett-yuxiang yes. When I originally wrote the linux install scripts, the instructions I provided in the README.md file were considering running the script from the root of the repository: https://github.com/githubnext/monaspace/pull/29/commits/29880d58671f6d1e28370d27dca04364cb8b48e7

Since then, it seems the instructions for both Mac and Linux have changed to first cd into the utils folder and run the script from there. Whoever did those changes also changed the mac os install script to refer to the parent path with .. but did not update the linux install scripts. That's what this PR is doing.

Finii commented 4 months ago

There are multiple PRs that fix the same thing. Ever looked through open PRs?

For example

idan commented 1 month ago

Fixed in the batch of commits around 93c4bcdb772fe34c4aef415a87e1521ae9947012. Thank you!