search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.12k stars 219 forks source link

docs(README): fix linux install command #198

Closed Merrit closed 1 month ago

Merrit commented 2 months ago

The script expects the cwd to be the root of the repo, the existing instructions that say to first change directory to util therefore fail.

Changes the instructions to run the script from project root, and installation succeeds.

Merrit commented 2 months ago

Not sure what you mean.. I tried to install after finding out about this project, and the instructions didn't work. I saw why, and contributed the fix so others wouldn't have the same issue.

Merrit commented 2 months ago

Never heard of "brushing the commit record" before, but from what I can tell via Google you are asking if I am trying to introduce a change that doesn't actually do anything; so I will break down the change as I see it:

Current instructions

"run the install script from the utils directory"

❌ This fails because the script is looking for directories in the repo root.

Changed instructions

"run the install script from the repo root directory"

✅ Now that it is run from the repo root, the script finds the folders it expects.

FWIW, I had to reinstall my OS over the weekend and I tried following the install instructions again, with the same issue. :woman_shrugging:

idan commented 1 month ago

Fixed in the batch of commits around 93c4bcdb772fe34c4aef415a87e1521ae9947012. Thank you!