search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.23k stars 215 forks source link

Add ligature for `/**` #2

Closed marvinruder closed 2 months ago

marvinruder commented 8 months ago

Monaspace offers a ligature for the character sequence /*, which looks good on its own, but when typing /** to start e.g. a Javadoc or JSDoc comment, only the first two characters get replaced by the ligature, the last asterisk remains unchanged and is now on a different height than the first one:

image

This does not look too aesthetically pleasing. Any chance we might find a ligature for the entire /** in a future version of Monaspace?

Ayesh commented 8 months ago

They are used quite extensively in the PHP world as well.

iwangbowen commented 8 months ago

I encountered the same problem and had to remove dlig to make it look better

techieshark commented 8 months ago

I had to remove dlig and ss07 to make it look better

pvanb commented 8 months ago

Maybe this belongs in a separate issue, but the sequence **/ also comes up and would benefit from its own ligature as well:

Screenshot 2023-11-13 at 12 16 30 PM

kieran-ryan commented 8 months ago

Maybe this belongs in a separate issue, but the sequence **/ also comes up and would benefit from its own ligature as well:

@pvanb, I have captured this as a separate issue (#122) as there appear to be a few unusual patterns that occur when using globs.

idan commented 2 months ago

Fixed in ca8015b