search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.12k stars 219 forks source link

v1.100 - ExtraBold fonts - nameID 2 is wrong #210

Closed kenmcd closed 1 month ago

kenmcd commented 1 month ago

In the v1.100 release all the ExtraBold fonts, Regular and Italic, have Bold and Bold Italic in nameID 2.

These should only be Regular or Italic.

idan commented 1 month ago

Investigating!

Finii commented 1 month ago

image

I'm not sure about this one (Bold flag in fsSelection and macstyle): At least it sets it consistently:

$ showttf  monaspace-v1.100/fonts/otf/MonaspaceXenon-WideExtraBold.otf 2>/dev/null | grep 'fsSelect|macstyle'
    macstyle=1
     fsSelection=160

While these have it not-set

$ showttf  ../Noto/Sans/NotoSans_Condensed-ExtraBold.ttf 2>/dev/null | grep 'fsSelect|macstyle'
    macstyle=0
     fsSelection=192
$ showttf  ../JetBrainsMono/NoLigatures/ExtraBold/JetBrainsMonoNL-ExtraBold.ttf 2>/dev/null | grep 'fsSelect|macstyle'
    macstyle=0
     fsSelection=192
$ showttf /usr/share/fonts/opentype/cantarell/Cantarell-ExtraBold.otf 2>/dev/null | grep 'fsSelect|macstyle' 
    macstyle=0
     fsSelection=64
$ showttf /usr/share/fonts/truetype/open-sans/OpenSans-ExtraBold.ttf 2>/dev/null | grep 'fsSelect|macstyle' 
    macstyle=0
     fsSelection=0

https://learn.microsoft.com/en-us/typography/opentype/spec/os2#fsselection

kenmcd commented 1 month ago

I'm not sure about this one (Bold flag in fsSelection and macstyle): At least it sets it consistently

That is a different issue, but a related problem. Mac-only bad habits vs. cross-platforn best practices.

GF FontBakery will definitely kick out the nameID 2 issue as an error which must be fixed. Not sure on the fsSelection flag issue. Have to check that.

idan commented 1 month ago

Should be fixed in e6f6278955d3c47a77c1bdbf442f60838667cb98! Thank you for the report 🥰