search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.98k stars 232 forks source link

Fix usage of `install_macos.sh` in README #71

Closed zanieb closed 4 months ago

zanieb commented 10 months ago

The provided suggestion to run ./install_macos.sh from the util directory fails since the script expects to be relative to the root of the content.

❯ cd util
❯ bash ./install_macos.sh
cp: ./fonts/otf/*: No such file or directory
cp: ./fonts/variable/*: No such file or directory

Avoiding the change to util and running bash ./util/install_macos.sh works.

A similar pull request exists for the Linux installation instructions at #104

shivan-s commented 10 months ago

Excellent PR.

brunofin commented 10 months ago

not sure why this was changed, I opened #26 (PR #29) for Linux installation and by the time my PR was merged, both MacOS and Linux instructions used bash ./util/install_XXX.sh instead. This PR needs to be merged, and if you could please also fix the Linux instructions the same way I'd be grateful.

brunofin commented 10 months ago

those changes were introduced by @idan here https://github.com/githubnext/monaspace/pull/29/commits/45c9887744307edea7b289eee4320280a59e93c6 upon merging my PR.

zanieb commented 10 months ago

Someone fixed the Linux instructions in #104 — there are already a bunch of duplicates so I'll just leave it separate.

idan commented 4 months ago

Fixed in the batch of commits around 93c4bcdb772fe34c4aef415a87e1521ae9947012. Thank you!