search

githubnext / monaspace

An innovative superfamily of fonts for code
https://monaspace.githubnext.com
SIL Open Font License 1.1
13.99k stars 233 forks source link

Make install script executable #8

Closed omgjlk closed 4 months ago

omgjlk commented 11 months ago

Without it being executable the install instructions fail.

sudo: ./util/install_macos.sh: command not found

prplecake commented 11 months ago

The instructions don't use sudo...

https://github.com/githubnext/monaspace/blob/421b5a8975c3d74f080a855802a05177a0fc1225/README.md?plain=1#L50-L52

What's more, the install script works in your home folder, so sudo isn't required.

omgjlk commented 10 months ago

Fair points.

I will argue though that by having a #! as a first line of the file including the interpreter to use, the install directions can be simplified to just ./util/install_macos.sh, assuming that the file is executable, which appears to be the intent.

idan commented 4 months ago

Fixed in 8847e6c809aae8afac2ea9e137850fe870862421

idan commented 4 months ago

Thank you for the PR, it's appreciated! Was fixed while I was doing a pass on the installation issues, this is not a rejection 💞