Add new prop and prevent default initialize

githuboftigran / rn-range-slider

A native slider with range

MIT License

234 stars 130 forks source link

Add new prop and prevent default initialize #117

Open Marcoo09 opened 2 years ago

Marcoo09 commented 2 years ago

In this pull request was:

Added a value prop to define a default value in case it's necessary
Fixed a problem from my point of view in which the updater was called each time the Slider is re-rendered.

Marcoo09 commented 2 years ago

Related issue #114

Marvedog commented 1 year ago

What's the hold up? This seems like a pretty done deal

Marcoo09 commented 1 year ago

What do you mean? My first point it's an improvement to have the ability of define a default value in the slider, for example you use the slider in edit mode and create mode, so the first time you want to render on 0 and the second time in the last value set. My second point it's a bug related the updater is called on the first render without touch anything.