search

githuboftigran / rn-range-slider

A native slider with range
MIT License
237 stars 133 forks source link

it will not working on Android if you does not set height in style property. why? #18

Closed nguyenap closed 4 years ago

githuboftigran commented 5 years ago

@nguyenap , because I was too lazy and didn't add support for automatic height calculation inside the view (so it can wrap it's content by default). Will try to find time and fix it in this weekend ;-) Thanks for reporting!

githuboftigran commented 5 years ago

I'm reopening this issue if you don't mind. Open issue will add some additional motivation to do that.

nguyenap commented 5 years ago

ok good. Hope it will be completed soon :)

genesy commented 4 years ago

Is this the reason I can't drag the sliders on android? or is that a different issue?

githuboftigran commented 4 years ago

@genesy , is your slider in a scrollable component? There is a similar open issue, I can't figure out why is it happening.

genesy commented 4 years ago

yeah i figured it out just now. it was in react-native-modal and i had to turn of it's swiping capabilities on android. works fine on ios tho

On Mon, Feb 24, 2020 at 4:46 PM Tigran Sahakyan notifications@github.com wrote:

@genesy https://github.com/genesy , is your slider in a scrollable component? There is a similar open issue https://github.com/githuboftigran/rn-range-slider/issues/20, I can't figure out why is it happening.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/githuboftigran/rn-range-slider/issues/18?email_source=notifications&email_token=AAJZDMEPRF6DELIUTUIEZWLREOCOPA5CNFSM4IA6YBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXAF5Q#issuecomment-590217974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJZDMHDHO6U6GMYJ5S4P2LREOCOPANCNFSM4IA6YBJA .

dev-sathish commented 4 years ago

The slider is not working for android. it shows Android not supported yet? even if we set both height and width in style props.

githuboftigran commented 4 years ago

@dev-sathish

it shows Android not supported yet? Nope, it doesn't show "Android not supported yet". And it IS working on android. Just follow the instructions in readme (link for react-native < 60, unlink for react-native >=60, styles, etc).