search

githuboftigran / rn-range-slider

A native slider with range
MIT License
237 stars 133 forks source link

1.3.0 does not work on RN <0.60 #30

Closed rafalzawadzki closed 4 years ago

rafalzawadzki commented 4 years ago

Due to this commit: https://github.com/githuboftigran/rn-range-slider/commit/fc2594c94500fdc4ca1d4360150c8d5b4c8c35b4

Android build fails, because androidx deps are missing.

A workaround for now (for <0.60) is to locally replace

import androidx.annotation.Nullable;
import androidx.core.view.ViewCompat;

with

import android.support.annotation.Nullable;
import android.support.v4.view.ViewCompat;
githuboftigran commented 4 years ago

@rafalzawadzki aaah, right... and with support lib it doesn't work on RN > 0.60 and you have to migrate to androidX from android studio

githuboftigran commented 4 years ago

@rafalzawadzki , did it work?

rafalzawadzki commented 4 years ago

@githuboftigran I decided to just use my workaround for the time being. We are upgrading RN soon anyways ;)

bilsak18 commented 4 years ago

It's sad how we have to work the issue around in such a non-proper way. Some people are still using lower versions of react-native, which makes it inappropriate for them to migrate to androidx yet :/