githubpartners / microsoft-learn

The planning and tracking of GitHub modules on MS Learn
7 stars 6 forks source link

NEW: Migrate your CI/CD Pipelines to GitHub with GitHub Actions Importer #58

Closed a-a-ron closed 1 year ago

a-a-ron commented 1 year ago

Module title: Migrate your CI/CD Pipelines to GitHub with GitHub Actions Importer

Outline doc: https://docs.google.com/document/d/1PBl6nNFQV8zeSc46kH5Vl-Y-ac0Xu4glF_uVb3sE-So/edit

Helpful resources

Module Outline

Screen Shot 2023-01-10 at 4 05 30 PM

camihmerhar commented 1 year ago

Howdy @ethanis!

Here is the outline for the GAI module! Would love to get your thoughts on what we have so far.

Here are a couple of questions we wanted your thoughts on as well:

Let @a-a-ron and me know if you have any questions!


Introduction

Learning Objectives

Prerequisites

Unit 1 - How to install GitHub Actions Importer CLI Extension and ensure its up-to-date

Unit 2 - How to execute GitHub Actions Importer commands and what is not automatically migrated

Exercise

Knowledge Check

Questions focused on the content we went over in the module

Summary

Quick review of what we learned in the module

More information on GAI:

JenniferKerns commented 1 year ago

Hello @camihmerhar! I have a few pieces of preliminary feedback to share:

question: Do you want me to read through the draft content?

camihmerhar commented 1 year ago

Hello @camihmerhar! I have a few pieces of preliminary feedback to share:

  • The link to the content for unit 2 actually links to unit 1
  • Our Field Engineering style guide (WiP!) includes some style decisions specific to GitHub Actions Importer. I'm happy to respond to any queries you might have about naming, language, etc.
  • The correct source for our labs repo is: https://github.com/actions/importer-labs
  • We need to keep a watchful eye out for any residual references to the code name Valet
  • I would probably rename the units. (something like: Unit 1 - How to install, update, and configure GitHub Actions Importer; Unit 2 - How to run GitHub Actions Importer commands/Unit 2 - How to use GitHub Actions Importer)

question: Do you want me to read through the draft content?

Howdy @JenniferKerns!

I would love your feedback on the drafted content, but only if you have time. I've pulled the majority of the content from the blog post you and Ethan wrote, so it would be great to know if I utilized anything out of context.

rmallorybpc commented 1 year ago

Hey @camihmerhar please let me know if you have any questions. - Ross

2-How-to-install,-update,-and-configure-GitHub-Actions-Importer.md I may break up the intro sentence, below or similar. Before we get into learning about the different commands you can run in GitHub Actions Importer. First, we'll review installation to ensure you have the most up-to-date version. Then we will learn about the supported CI platforms.

3-How-run-GitHub-Actions-Importer-commands.md "Forcast" to "Forecast" in the first bullets. Add a space after the comma in, "for example,build tasks or build triggers" "How to run the forecast commmand", change to, "command" "isLiteral: true", change to, "isLiteral" In "Once you initiate the command it will provide an Audit Summary report" and "Let’s go over the details the Audit Summary report will provide you, make "summary" lowercase Add a space after the comma, "(for example,build tasks or build triggers)" "When you are defining an organization-level allowlist", change to "allow list" "In the next section we’ll be going over the" and "In this section we’ll be reviewing how to run the" maybe add a comment after "section". There are some other section intros that could include the comma as well. Does "migrate" need to be formatted as code, "You can use the migrate command"? Do we want to link out from this unit in, "For specific differences for supported CI platforms please reference the following links"

rmallorybpc commented 1 year ago

@camihmerhar here is my latest review. Please let me know if there are any questions.

1-introduction.md

2-How-to-install,-update,-and-configure-GitHub-Actions-Importer.md

3-How-run-GitHub-Actions-Importer-commands.md

a-a-ron commented 1 year ago

Hey @camihmerhar. After our 1:1 today and taking some time to review the module, I have some thoughts that I'll address by each file.

2-How-to-install,-update,-and-configure-GitHub-Actions-Importer.md

(We need to remove the commas in the file name)

As we discussed, I agree that the current install/update information is redundant since we cover it at the beginning of each available lab. I propose that we remove this information and repurpose this unit to better explain and introduce GAI. For example, in the introduction unit, we say that GAI is designed to help you forecast, plan, and facilitate migrations to GitHub Actions but we then move right into steps to install it and then move right into the 4 commands (audit, forecast, dry-run, and migrate). I feel like we are missing the connection between the initial introduction with the learning objectives and the 4 commands that will be used.

What are your thoughts on removing the install/update content and add some content to introduce each section that GAI is designed to help you with (forecast, plan, and facilitate). We can use this unit to provide a high-level overview of why these phases are important or needed and the transition to the 4 commands that are relevant to these areas. I think it will flow better. I don't want to copy/paste content from the blog post but If we could summarize that content into this unit before introducing the 4 commands then I think that would help fill this gap.

3-How-run-GitHub-Actions-Importer-commands.md

This unit looks pretty good. I would remove the entire links section at the top (lines 14-19). We introduce these commands at the top so I think this is redundant and I don't want the learner to jump around. I like that we continue to talk about the lab at the beginning of the unit, but I don't want to link to the lab right now. That will prompt the learner to leave the module before we discuss the content in the unit.

5-exercise.md

Can we reformat this unit to match our other exercise units? We can just link out to the lab instead of providing the learning lab section that is included in the importer-labs repo. Here's an example of an exercise file. We just need to edit the content to introduce these specific labs and then change the link.