githubpsyche / pcitpy

The Probabilistic Curve Induction and Testing (P-CIT) toolbox, implemented in Python.
https://githubpsyche.github.io/pcitpy/
Apache License 2.0
0 stars 0 forks source link

validate `family_of_curves` #30

Open githubpsyche opened 4 years ago

githubpsyche commented 4 years ago

Continuing from #5, but with the new policy of creating new issues for new issues instead of just dumping all commentary related to family_of_curves here. I'll reference this issue where relevant so that I can still go here to keep track of existing and finished problems.

githubpsyche commented 4 years ago

There are quite a few "options" for this one but the real ones (i.e the ones w/ substantial associated code) are compute_likelihood, count_particles, get_curve_xy_vals.

Where are they used?

So as long as I validate both simulate_data and importance_sampler, I'll get family_of_curves along the way.

githubpsyche commented 4 years ago

A bug indexing cluster_idx in compute_likelihood is handled in #34