githubschool / blue-moon

Let's learn about Git and GitHub
https://githubschool.github.io/blue-moon/
MIT License
0 stars 1 forks source link

Parking Lot #9

Open ericalloyd opened 4 years ago

ericalloyd commented 4 years ago

Post any questions you may have here during the training.

Derek-Chang-BCBSA commented 4 years ago

Looks like there are some clear advantages for using GitHub cloud, what are the benefits for using on-prem GitHub?

ericalloyd commented 4 years ago

Recordings Will Be Posted Here

Day 1 - Wed, April 29, 2020

Meeting Recording: https://github.zoom.us/rec/share/-M9aK4nr0l9LbYX85XDWAq9-JaLBeaa823VIqPMFz0anQcaWVbwpHjuWgu-5RmHc

Access Password: 0f%!945@

madanmn commented 4 years ago

If GITHUB has CI/CD capabilities do we need tools like Jenkins

ericalloyd commented 4 years ago
ericalloyd commented 4 years ago
umagitac commented 4 years ago

Can we have different set of branch protection rules based on different group of users? e.g. any pull request from usergroup1 should be approved by minimum 2 reviewers and for usergroup2 by at least 1 reviewer on a specific branch?

vila89 commented 4 years ago

Script to check branch protections across repos and update them/enforce rules

GitHub has an API to check branch protections https://developer.github.com/v3/repos/branches/#get-branch-protection

We have a script to check for branch protections and enforce the protection using Jenkins pipeline: https://developer.github.com/v3/repos/branches/#get-branch-protection

vila89 commented 4 years ago

Can we have different set of branch protection rules based on different group of users? e.g. any pull request from usergroup1 should be approved by minimum 2 reviewers and for usergroup2 by at least 1 reviewer on a specific branch?

The best way to do this is probably to use a different branch for different user groups so that rules can vary for different branches

In addition, users/teams can be auto assigned to be the reviewers of a pull request using the CODEOWNERS file (Erica will cover this as part of the training)

cc: @umagitac

ericalloyd commented 4 years ago

You'll need to have site-wide Admin rights. Go to Admin Center => Settings => Force Pushes section

This does not include all of the branch protection options available from within the repo, but you can enable this to prevent force pushing to the default branch. This is a new option!

Screen Shot 2020-04-29 at 11 29 42 AM

umagitac commented 4 years ago

We create TAGs for each milestone (release to QA) on a specific branch. And, on the same branch the development team continues to push commits. If we want to give a patch on a specific tag , what do you think is the best way to achieve this? Can we include additional commits (only specific) to a TAG? How do we handle Pull Request and merge to the TAG?

umagitac commented 4 years ago

Do you have a sample Pull Request that demonstrates best practices and usage of most of the features of PR/Git Workflow?

saikothuru commented 4 years ago

Can we spend few mins to talk/install/use basic features of a GitHub App? A simple use case what we would want if want to ran a sonar scan on every branch which gets created in a repository.

ericalloyd commented 4 years ago
lavpersonal commented 4 years ago

Can you please talk more about upstream and fork concepts? what is the best practice to create a branch? Is it from origin( having your own fork) or upstream?

ericalloyd commented 4 years ago

The branch is not actually deleted. References to it will still be preserved.

ericalloyd commented 4 years ago
ericalloyd commented 4 years ago

GitHub CLI https://cli.github.com/

ya08431 commented 4 years ago

can you please send day2 recording

vila89 commented 4 years ago

Day 2: Recording

Date: Apr 30, 2020 1PM Eastern Time (US and Canada)

Meeting Recording: https://github.zoom.us/rec/share/1ZVOKYnv70ROaJXC2GSCWv9iMrbAaaa82ndP__QJmEqNUOPQ-2E1uBXEyS0EhEed

Access Password: 1E@t9Q3D