Parking Lot

[githubteacher]

Post any questions you may have here during the training.

[ericalloyd]

🎥 Recordings will be posted here

Day 1 - Wednesday, April 14, 2021

Zoom Link: https://github.zoom.us/rec/share/4TJnTCluE0sv4Zx66IhPbCcGd69tIqQtEk8jIxGDOvlmXHwc7X3TeLqf6BHOkRk.UOB-G4_SRDnAx-rk

Passcode: mI?53BTM

Day 2 - Thursday, April 15, 2021

Zoom link: https://github.zoom.us/rec/share/VDOdNh4ewaBnTrpVTn8Sn9gH3JFFw6sRakfc78uAZXmgDbQl4U6nJrsdkjsM3o5P.CNkXHX8vrTG92EKq

Passcode: Q?v4VC9A

[ericalloyd]

Questions & Answers:

• [x] How to link to Jira tickets

[cassella]

Is there a way to get to my invitations-to-repositories through the github web interface? That is, without having to find the emails in the flood of PR emails from this morning, and without having to start with the URL of the invited-to repo to modify with /invitations?

This morning I was able to find the invite to orbits in my bell icon notification list, but I can't find the two new ones there. (In fact, I can't find the invitation to orbits there now either.)

[cassella]

When reviewing a PR, is there a way to get a diff between two different commits in the review's history using the web interface? That is, if I've spent an hour reviewing a PR and left comments, and the developer addresses those comments by rewriting the commit and force-pushing, can I see just what's changed since the commit I reviewed? (After the "changes since you last viewed" has disappeared.)

The last time I tried that, I couldn't figure out how to view the original commit through the web interface.

I know I can do it through the commandline if I've fetched the PR branch and tagged it before the force push, but I don't usually think to do that until I see that there's been a force push.

[ericalloyd]

When reviewing a PR, is there a way to get a diff between two different commits in the review's history using the web interface? ...

@cassella:

Yes! On the "Files Changed" tab at the menu on the top left, there is a "Changes from:" dropdown. It defaults to "all commits". You can change it to select "Show changes since your last review", or select a specific commit range.

[ericalloyd]

• [ ] How to link to Jira tickets

@Gary-Elsesser:

• If you want to automatically link to JIRA urls, you can enable a feature called Autolink References (Settings => Autolink References => Add). It allows you to set a pattern that will generate a hyperlink anytime that pattern is used.

  

  Walkthrough here: https://docs.github.com/en/github/administering-a-repository/configuring-autolinks-to-reference-external-resources

• If your organization uses Jira Cloud, there is a Jira + GitHub App available in GitHub Marketplace to fully connect your repositories with Jira projects!

[ericalloyd]

Is there a way to get to my invitations-to-repositories through the github web interface? That is, without having to find the emails in the flood of PR emails from this morning, and without having to start with the URL of the invited-to repo to modify with /invitations?

This morning I was able to find the invite to orbits in my bell icon notification list, but I can't find the two new ones there. (In fact, I can't find the invitation to orbits there now either.)

@cassella:

• At this time, there is not an "Invitations" notification stored in the interface. Once you have accepted an invite, either via email or in the browser, the invitation is no longer accessible.

• To avoid the slew of emails, you can go to your Notifications page and deselect "Email". This way you will only receive notifications via the interface (bell icon).

  

• You can also target the notifications you want within each repository, and even for specific PRs and issues. See the walkthrough here: Configuring Notifications

[MattPD]

I'd be interested in the suggested fixes (possibly including on-prem GitHub instance configuration if applicable as a workaround) to the following errors that came up in practical workflow using GitHub for the LLVM (one of the projects we're working with):

• Display file: Number of lines limitation.
  • Error: "This file is too large to render. Download the full file." after 20,000 lines.
  • e.g., https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/X86/X86ISelLowering.cpp
• Search: Number of lines limitation.
  • Suppose I have now accessed the raw file: https://raw.githubusercontent.com/llvm/llvm-project/release/12.x/llvm/lib/Target/X86/X86ISelLowering.cpp
  • I can see the name of the last function: X86TargetLowering::getPrefLoopAlignment
  • Error: However, no results when searching on GitHub: https://github.com/llvm/llvm-project/search?q=X86TargetLowering%3A%3AgetPrefLoopAlignment
• Display directory: Number of files limitation.
  • Error: "Sorry, we had to truncate this directory to 1,000 files. 160 entries were omitted from the list. "
  • e.g., https://github.com/llvm/llvm-project/tree/main/llvm/test/CodeGen/AArch64
• Search: Limit to specific (sub)directories and specific file patterns
  • e.g., as in
    • only in the subdirectories of llvm/lib/Target/X86: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/llvm-project/llvm-project%24%40ea0411e+file:%5Ellvm/lib/Target/X86/%5C.*+supportSwiftError&patternType=literal
    • only file name starting with "X86F": https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/llvm-project/llvm-project%24%40ea0411e+file:%5Ellvm/lib/Target/X86/X86F%5C.*+supportSwiftError&patternType=literal
  • Error: GitHub always performs global search and doesn't expose functionality of git grep, https://git-scm.com/docs/git-grep
• Search: Missing results
  • example: https://github.com/llvm/llvm-project/search?q=isREVMask
  • file not listed among the results even though it contains isREVMask: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  • in contrast: https://sourcegraph.com/search?q=repo:github.com/llvm-project/+isREVMask&patternType=literal
  • Error: file not listed among the search results even though it contains the keyword

[ericalloyd]

I'd be interested in the suggested fixes (possibly including on-prem GitHub instance configuration if applicable as a workaround) to the following errors that came up in practical workflow using GitHub for the LLVM (one of the projects we're working with):

• Display file: Number of lines limitation.

  • Error: "This file is too large to render. Download the full file." after 20,000 lines.
  • e.g., https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/X86/X86ISelLowering.cpp

• Search: Number of lines limitation.

  • Suppose I have now accessed the raw file: https://raw.githubusercontent.com/llvm/llvm-project/release/12.x/llvm/lib/Target/X86/X86ISelLowering.cpp
  • I can see the name of the last function: X86TargetLowering::getPrefLoopAlignment
  • Error: However, no results when searching on GitHub: https://github.com/llvm/llvm-project/search?q=X86TargetLowering%3A%3AgetPrefLoopAlignment

• Display directory: Number of files limitation.

  • Error: "Sorry, we had to truncate this directory to 1,000 files. 160 entries were omitted from the list. "
  • e.g., https://github.com/llvm/llvm-project/tree/main/llvm/test/CodeGen/AArch64

• Search: Limit to specific (sub)directories and specific file patterns

  • e.g., as in

  • only in the subdirectories of llvm/lib/Target/X86: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/llvm-project/llvm-project%24%40ea0411e+file:%5Ellvm/lib/Target/X86/%5C.*+supportSwiftError&patternType=literal

  • only file name starting with "X86F": https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/llvm-project/llvm-project%24%40ea0411e+file:%5Ellvm/lib/Target/X86/X86F%5C.*+supportSwiftError&patternType=literal

  • Error: GitHub always performs global search and doesn't expose functionality of git grep, https://git-scm.com/docs/git-grep

@MattPD

I'll bring in @michaelsainz to follow up on this with you. During the developer training we wouldn't be diving into configuration or error troubleshooting.

[MattPD]

@ericalloyd Thank you, I appreciate it!

[ericalloyd]

Feedback/Request:

• Command line instructions for resolving merge conflicts instructs to push to main. Best practices we recommend are not to push to main. Can we modify this?

[ericalloyd]

Create conflict and games repos for: @JajuRamanuj-hpe @damrkul

[ericalloyd]

• [ ] Force push best practices

[ericalloyd]

• [ ] Link to probot app to specify codeowners from groups

[ericalloyd]

• [ ] @michaelsainz Please follow up with @haasken-hpe regarding Admin/Automation training - auto-managing and assignment of teams

[sewatters]

Please leave link and code for Day 2 recording. Thanks!

[sewatters]

I'm also interested in admin/automation training.

[datle79]

happy to attend more training! admin, automation and deep dive into Github Actions.

[cassella]

Yes! On the "Files Changed" tab at the menu on the top left, there is a "Changes from:" dropdown. It defaults to "all commits". You can change it to select "Show changes since your last review", or select a specific commit range.

Thanks! But that's not working for me when I try to compare to a commit that a force push removed. I'm trying to see what's different in the PR between the previous review point and after a force-push. E.g., to verify that squashing all the commits down to one didn't result in any changes.

I tried a PR where I force pushed a few times, but when I try the "Show changes from your last review", I just get an error page:

https://github.com/githubschool/github-games-cassella/pull/4/files/bb6991ad0f26bfdaa0da40143cfd7ff534276098..HEAD

Is that "Changes from" dropdown menu conditional on something? I looked at a PR with multiple commits in a different repo, and that option isn't available on the view changes page. I just see the File filter, Jump to, and Gear icon.

[MattPD]

@michaelsainz Feel free to let me know if you have time to follow up on https://github.com/githubschool/orbit/issues/7#issuecomment-820464252 Thanks!

[ericalloyd]

@cassella Regarding the force push specifically: when commits are force pushed, history of the branch is rewritten, so in that case you would not be able to view the diff for any commits that were overwritten. They are no longer on the branches history.

I'm not sure why you're unable to view the comparison options in general, and will have to look into that further.