githubsrinath / geomodel

Automatically exported from code.google.com/p/geomodel
0 stars 0 forks source link

geomodel's update_location calls geocell inappropriately #6

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. running entity.update_location()

What is the expected output? What do you see instead?
Although no error is returned for certain lat/lon pairs, because geomodel
is passing just a latitude instead of the point object expected by geocell,
you may see an error for certain inputs.  Whether an error is raised or
not, the computation seems incorrect.

What version of the product are you using? On what operating system?
n/a

Please provide any additional information below.
update_location should call compute with a point object rather than
(lat,lon).  Attached is a patch.  Side note: my personal patch also allows
update_location to accept an optional resolution that gets passed to
compute if there's interest in that.

Original issue reported on code.google.com by joshli...@gmail.com on 3 Jun 2009 at 9:27

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the report and patch! Will take a look tomorrow.

Original comment by api.roman.public@gmail.com on 4 Jun 2009 at 1:18

GoogleCodeExporter commented 9 years ago
I've applied the patch, thanks :)

Original comment by api.roman.public@gmail.com on 4 Jun 2009 at 6:58