Unhappy Path: Branches and PRs

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡

https://github.com/githubtraining/ci-circle-template

Creative Commons Attribution 4.0 International

3 stars 9 forks source link

Unhappy Path: Branches and PRs #11

Closed carolynshin closed 5 years ago

carolynshin commented 5 years ago

Tasks

@beardofedu to review course: 12/17

[ ] Review course, identify any issues and address each point below.
- [ ] What if user creates wrong branch name?
- [x] What if they create the wrong PR / wrong base:
[ ] @hollenberry to respond to reviews/code fixes: 12/18

carolynshin commented 5 years ago

@beardofedu 👋 - We're still good to start the review tomorrow (12/11 - 12/12) but please wait till @hectorsector to give you the :+1:! Thank you.

hectorsector commented 5 years ago

@beardofedu you're good to test 👍 sorry for the delay.

You'll have to use my placeholder responses until #34 ships, but you can look there if you need some extra context for what you're asked to do, or just ask :)

carolynshin commented 5 years ago

Updating OP.

@beardofedu to review course (12/17) and @hollenberry to add fixes (12/18).

beardofedu commented 5 years ago

@a-a-ron | @hollenberry

What if they create the wrong PR / wrong base:

The course proceeds as if I created the branch correctly. I can create the text to display when they select the wrong branch. I just need the config to successfully test for the branch used.

What if user creates wrong branch name?

The student doesn't create a branch in this course