Closed todo[bot] closed 5 years ago
@ppremk we need the first PR created by the learner to result in a failed build. I'll leave up to you whether you want the failed build to be in a new branch, or we can ask the learner to take some action that results in a failing build.
This is true, @ppremk. In my most recent iteration, we need:
I did this in the two latest commits on master
of your template:
However, it needs to be cleaned up as it was quickly done through reverts. For now, this works for the course as-is so it's not a blocker. I'm updating the title of this issue to reflect the true nature of the problem.
Noted on the changes @hectorsector. Will proceed to close this since it is not a blocker and also since are are aligned.
https://github.com/githubtraining/ci/blob/322b170e4033f3adcaa24f0b2ec4d54d84288608/config.yml#L33-L38
This issue was generated by todo based on a
template-repo
comment in 322b170e4033f3adcaa24f0b2ec4d54d84288608 when #3 was merged. cc @githubtraining.