search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

need a branch with broken links #19

Closed todo[bot] closed 5 years ago

todo[bot] commented 5 years ago

https://github.com/githubtraining/ci/blob/56937ff7f31d29b9aadc4be532a7c5479d5d1633/config.yml#L93-L95

hectorsector commented 5 years ago

I updated the OP with a new snapshot of the config, and changed the title of this issue. We need a branch with broken links to test the link validator (or image checker, whatever we decide to go with).

ppremk commented 5 years ago

-ok I shall proceed to fix the template repo to be able to accommodate this

hectorsector commented 5 years ago

To clarify, the learner will be asked to merge in the changes from add-links into their branch after they add the link validation. Doing so, should result in broken links that they can fix. I tried doing this by changing the README or other markdown files, but the builds came back successful so I'm not sure if I'm doing something wrong.

This is still a need 👍

hectorsector commented 5 years ago

Based on our conversation in Slack, we now just need for the add-links branch to have broken links in docs/README.md. That will be sufficient for us to ask the learner to fix them and complete this step, @ppremk.

ppremk commented 5 years ago

@hectorsector I leave it up to you to close this issue in favor of what is discussed here https://github.com/githubtraining/ci/issues/35

hectorsector commented 5 years ago

The most recent template repo should have this.