search

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

grab branch from the template repo for PR 6: Add CD #29

Closed todo[bot] closed 5 years ago

todo[bot] commented 5 years ago

https://github.com/githubtraining/ci/blob/29267e260a9f77d0c4410be9210b9e5e28513af7/config.yml#L156-L161

This issue was generated by todo based on a todo comment in 29267e260a9f77d0c4410be9210b9e5e28513af7 when #23 was merged. cc @githubtraining.
ppremk commented 5 years ago
hectorsector commented 5 years ago

@ppremk let's not require a branch for deployment. I think we can simply deploy to GitHub Pages. It would be a good idea to have a PR ready with the Heroku configuration in one of the extra PRs that are opened after the course is completed.

ppremk commented 5 years ago

@ppremk let's not require a branch for deployment. I think we can simply deploy to GitHub Pages. It would be a good idea to have a PR ready with the Heroku configuration in one of the extra PRs that are opened after the course is completed.

agreed @hectorsector 🙂

ppremk commented 5 years ago

@hectorsector I leave it up to you to close this issue in favor of what is discussed here https://github.com/githubtraining/ci/issues/35

hectorsector commented 5 years ago

The most recent template repo should have this.