Address feedback for first round of logic

githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡

https://github.com/githubtraining/ci-circle-template

Creative Commons Attribution 4.0 International

3 stars 9 forks source link

Address feedback for first round of logic #33

Closed hectorsector closed 5 years ago

hectorsector commented 5 years ago

This PR closes #9.

hectorsector commented 5 years ago

@ppremk I think this addresses all your feedback. I'm merging it which will close #9 but if you still find I missed something, please don't hesitate to reopen #9.

@a-a-ron this should give you what you need to write up the responses. I'm sorry it took me all day. Let me know if there's anything I can do to help.