githubtraining / ci-circle

Course repo for Learning Lab course "Continuous Integration with CircleCI". Template repo ➡
https://github.com/githubtraining/ci-circle-template
Creative Commons Attribution 4.0 International
3 stars 9 forks source link

Recover when no branch protection is present #45

Closed hectorsector closed 5 years ago

hectorsector commented 5 years ago

We check if the learner turned on branch protection as we asked:

https://github.com/githubtraining/ci/blob/ebed663338640d1c2544250a66fb7e329724e467/config.yml#L148-L153

If they didn't, it breaks the course and learner can't get past this step.

brianamarie commented 5 years ago

Currently, the course has protected branches for the beginning, but not at this step. I merged instead of changing permissions, and no notification was given. Then, I went back and changed the permissions, and still nothing happened. In relation to #61, I think it makes the most sense to:

I'll start working on this 👍

brianamarie commented 5 years ago

This is fixed in #67