Gather list of SMEs for course feedback

[carolynshin]

@hollenberry, would you be gather a list of subject matter experts in CI and also reach out to them to see if they are available this month to provide course feedback?

Dates: 12/6/18 - 12/7/18

Based on the project plan, we could use some help in reviewing the course on December 19th, 2018. But obviously, depending on what @hectorsector needs, we can bring them in sooner.

[carolynshin]

@hollenberry 👋 saw this team post draft, how exciting! Can you estimate when this will be complete by so I can update the project dates?

[hollenberry]

@carolynshin I'm hoping for early reviews this week on the team post. While the list may take some extra time to generate, I expect the original project dates and reviews to take place as expected.

At absolute minimum, we can have a few services-engineers take a look, since they often advocate for this and would be some true company experts based on workflow consultations.

[carolynshin]

At absolute minimum, we can have a few services-engineers take a look, since they often advocate for this and would be some true company experts based on workflow consultations.

@hollenberry that sounds great :+1:! Based on the schedule, we will need testing until Dec 19th. Here's the services engineering schedule for this week and next week (till Dec 19th):

It looks like only stoe, mattcantstop, and possibly SAEs are available on the actual Dec 19th date. Would you be able to reach out to see who can spend time on Dec 19th for review? (Unless we want an earlier review).

[carolynshin]

Hubbers who are available to help test course I've let them know it should take approximately 20 min to go through the course.

• @primetheus
• @michaelsainz
• @jwiebalk

@beardofedu, @hollenberry - please let me know when this course should be ready to be reviewed by them. I told them we'd probably be reaching out to them on Dec 19th based on our schedule here.

[carolynshin]

@brianamarie or @hollenberry think we might be able to reach out to our contacts at Travis and/or Circle to review the course? We can put it in the sandbox instance -- it'd be valuable feedback.

Bringing @hectorsector's ask to this issue. @brianamarie / @hollenberry - can we reach out to our contacts today to see if they have any availability this week? And then we can work on fixes the first week of Jan.

[hollenberry]

@primetheus @michaelsainz @jwiebalk, we're still putting the final touches on the course, but this is ready for your review today!

We're currently trying to break the course within reason (unhappy path testing).

If you take the course and follow the prompts as expected (happy path testing), we'd love your thoughts and input for response content and course flow.

We know that you have these conversations all the time, and we'd love your help identifying where customers may typically get stuck with CI at the introductory level.

[jwiebalk]

Running through this now and ❤️ it so far.

Only thing I've noticed so far is on PR#4 using the suggested changes it seems to have added the line instead of replacing it. Not sure if this is a suggested changes bug or maybe we're suggesting changes against the wrong line here:

      - run:
          name: run html proofer
          command: REPLACE-ME-WITH-SCRIPT
          command: bundle exec htmlproofer ./_site --check-html

Also I'm not sure if there's anyway to improve the test speed but it seems just long enough that I switch to a different task and then have to remind myself to come back 😸

[hollenberry]

Only thing I've noticed so far is on PR#4 using the suggested changes it seems to have added the line instead of replacing it. Not sure if this is a suggested changes bug or maybe we're suggesting changes against the wrong line here:

Good catch! I tried to fix this in #58 , but we'll keep an eye on it on the next round of tests.

Also I'm not sure if there's anyway to improve the test speed but it seems just long enough that I switch to a different task and then have to remind myself to come back 😸

@ppremk is looking into this via #59 . Hopefully we address this soon.

Thank you for reviewing @jwiebalk !

[ppremk]

@ppremk is looking into this via #59 . Hopefully we address this soon.

This is now resolved. We use our own custom Docker container with all required dependency installed to speed up the process.

[hectorsector]

👋 @carolynshin @hollenberry is this good to close or are we still able to get feedback from folks? It occurs to me @primetheus and @michaelsainz maybe don't have access to this org and repo?

[michaelsainz]

Just finished it - this is great!

On PR#3 after you commit, Galileo's follow-up comment contains the sentence "it's time to turn edit the branch protections." which doesn't make sense. "...turn edit..."? Think it's supposed to be "it's time to edit the branch protection to enable it on master".

[michaelsainz]

Figured I'd just go ahead and fix is - #99

[hectorsector]

This is done!